Hadrian, thanks! These comments were addressed in:
https://github.com/apache/incubator-brooklyn/pull/874
Best
Alex
On 02/09/2015 01:43, Hadrian Zbarcea wrote:
Below are the (only) comments from the previous release. I don't know
where to get the respective licenses for the ui stuff, it would be
good to add them to the ./LICENSE file (and remove the MIT and BSD lics).
Cheers,
Hadrian
Minor issues:
- LICENCE is missing standard appendix
- probably no need for the full text of MIT and BSD as the short
version is preferred and already used
- LICENSE is missing:
riak (see
./software/nosql/src/main/resources/brooklyn/entity/nosql/riak/vm.args
+ others)
normalize.css (see
./sandbox/mobile-app/src/main/webapp/assets/mobile/libs/mcasimir-mobile-angular-ui-be39011/dist/css/mobile-angular-ui-base.css)
mobileangular-ui (see
./sandbox/mobile-app/src/main/webapp/assets/mobile/libs/mcasimir-mobile-angular-ui-be39011/dist/js/mobile-angular-ui.js)
r.js (see ./usage/jsgui/src/build/requirejs-maven-plugin/r.js)
angular (see
./sandbox/mobile-app/src/main/webapp/assets/mobile/libs/angular-1.2.19)
--
Cloudsoft Corporation Limited, Registered in Scotland No: SC349230.
Registered Office: 13 Dryden Place, Edinburgh, EH9 1RP
This e-mail message is confidential and for use by the addressee only. If
the message is received by anyone other than the addressee, please return
the message to the sender by replying to it and then delete the message
from your computer. Internet e-mails are not necessarily secure. Cloudsoft
Corporation Limited does not accept responsibility for changes made to this
message after it was sent.
Whilst all reasonable care has been taken to avoid the transmission of
viruses, it is the responsibility of the recipient to ensure that the
onward transmission, opening or use of this message and any attachments
will not adversely affect its systems or data. No responsibility is
accepted by Cloudsoft Corporation Limited in this regard and the recipient
should carry out such virus and other checks as it considers appropriate.
