Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/880#discussion_r38852926
--- Diff:
software/base/src/test/java/org/apache/brooklyn/entity/software/base/test/mysql/DynamicToyMySqlEntityBuilder.java
---
@@ -88,18 +87,15 @@ public static final String dir(Entity e) {
public static String getOsTag(Entity e) {
// e.g. "osx10.6-x86_64"; see
http://www.mysql.com/downloads/mysql/#downloads
OsDetails os =
((SshMachineLocation)Iterables.getOnlyElement(e.getLocations())).getOsDetails();
- if (os == null) return "linux-glibc2.5-x86_64";
+ if (os == null) return "linux2.6-x86_64";
if (os.isMac()) {
- String osp1 = os.getVersion()==null ? "osx10.8" //lowest
common denominator
- : new
ComparableVersion(os.getVersion()).isGreaterThanOrEqualTo(OsVersions.MAC_10_9)
? "osx10.9"
- : "osx10.8"; //lowest common denominator
if (!os.is64bit()) {
throw new IllegalStateException("Only 64 bit MySQL build
is available for OS X");
}
- return osp1+"-x86_64";
+ return "osx10.6-x86_64";
--- End diff --
Why revert from 10.8/9 to 10.6? The tests pass, I just want to double check
your thinking.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
