Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/877#discussion_r38927546
  
    --- Diff: 
core/src/main/java/org/apache/brooklyn/location/ssh/SshMachineLocation.java ---
    @@ -152,6 +152,12 @@
         public static final ConfigKey<Boolean> DETECT_MACHINE_DETAILS = 
ConfigKeys.newBooleanConfigKey("detectMachineDetails",
                 "Attempt to detect machine details automatically. Works with 
SSH-accessible Linux instances.", true);
     
    +    public static final ConfigKey<Boolean> BYON_USER_RESET_LOGIN = 
ConfigKeys.newBooleanConfigKey(
    --- End diff --
    
    this should be a config on `CreateUserPolicy` as that is the only thing it 
affects, and it affects everything there
    
    on a different note if that policy is tied to jclouds it will have no 
effect on BYON deployments.  if it isn't related to jclouds it should probably 
be moved to the policies project and a different package.  (we should leave the 
old instance in place as an empty class extending the item in the new location, 
but deprecated, so that references to the old one will still work.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to