Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/886#discussion_r39148821
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/internal/BasicExternalConfigSupplierRegistry.java
---
@@ -103,7 +103,7 @@ private void
updateFromBrooklynProperties(ManagementContext mgmt) {
try {
Class<? extends ExternalConfigSupplier> providerClass =
(Class<? extends ExternalConfigSupplier>)
classloader.loadClass(providerClassname);
Constructor<? extends ExternalConfigSupplier> constructor
= providerClass.getConstructor(ManagementContext.class, String.class,
Map.class);
- ExternalConfigSupplier configSupplier =
constructor.newInstance(this, name, config);
+ ExternalConfigSupplier configSupplier =
constructor.newInstance(mgmt, name, config);
--- End diff --
The constructor in `AbstractExternalConfigSupplier` only has
`ManagementContext` and `String` arguments. Is it safe to assume that
implementors will always provide an implementation with the third `Map`
argument?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
