Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/887#discussion_r39534483
--- Diff:
core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java
---
@@ -800,7 +809,11 @@ private boolean attemptType(String key,
CatalogItemType candidateCiType) {
// (when we're not given a key, the previous block
should apply)
errors.add(e);
} else {
- // all other cases, the error is probably due to us
not getting the type right, ignore it
+ // all other cases, the error is probably due to us
not getting the type right, probably ignore it
+ // but cache it if we've checked entity, we'll use
that as fallback errors
--- End diff --
we're parsing CAMP, then CAMP refers to something in catalog. the code
before this change would use camp-specific logic to handle the catalog entry
making use of the parent entity's class loading context if needed. but that
breaks if it refers to a non-camp non-java catalog item (eg tosca). so this
now also looks it up using the catalog mechanism (although in that case it does
not have any default class loading context.)
the CLC should only matter for java types. it's working now, but would
like to clean this whole area up massively!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
