[ 
https://issues.apache.org/jira/browse/BROOKLYN-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14805069#comment-14805069
 ] 

ASF GitHub Bot commented on BROOKLYN-166:
-----------------------------------------

Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/865#discussion_r39827764
  
    --- Diff: 
usage/jsgui/src/main/webapp/assets/js/view/application-add-wizard.js ---
    @@ -591,10 +607,14 @@ define([
                         return true
                     }
                 } else if (tabName=='#yamlTab') {
    -                this.model.yaml = this.$("#yaml_code").val();
    -                if (this.model.yaml) {
    -                    return true;
    -                }
    +                   if (self.editor && self.editor) {
    +                           this.model.yaml = self.editor.getValue();
    +                           if (this.model.yaml) {
    +                       return true;
    +                           }
    +                   } else {
    +                           console.info("No text in the editor!");
    +                   }
    --- End diff --
    
    This block has a wrong indentation.


> Use a feature rich yaml editor
> ------------------------------
>
>                 Key: BROOKLYN-166
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-166
>             Project: Brooklyn
>          Issue Type: Improvement
>            Reporter: Hadrian Zbarcea
>             Fix For: 0.8.0
>
>
> Brooklyn would benefit from a feature rich editor that would give a user more 
> feedback on what is possible when editing a camp blueprint.
> The best candidate is imho codemirror, used by many apps, including swagger.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to