GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/908
Fix jboss service not up
Previously, serviceUp was never set to true, for two reasons:
1. because connectServiceUpIsRunning was not called, nothing was
unsetting the service-not-up-indicator for SERVICE_PROCESS_IS_RUNNING
2. because the service-not-up-indicator for MANAGEMENT_URL_UP said
suppressDuplicates=true, then it checked if the map was equal to
the âoldâ map before publishing. But the map was the same object,
and that object had been modified in-place. So the object was
always equal to itself. It therefore never did an emit(), so the
enricher that listened to it to set serviceUp never fired.
Also fix UpdatingMap for if suppressDuplicates=true:
- log.warn to say it should not be set.
- reset config to suppressDuplicates=false
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn
fix/jboss-serviceNotUp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/908.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #908
----
commit 6ecbb27e7e349b1823d0634b8342f0c0925103ec
Author: Aled Sage <[email protected]>
Date: 2015-09-19T14:41:05Z
Fix jboss7 serviceUp
Previously, serviceUp was never set to true, for two reasons:
1. because connectServiceUpIsRunning was not called, nothing was
unsetting the service-not-up-indicator for SERVICE_PROCESS_IS_RUNNING
2. because the service-not-up-indicator for MANAGEMENT_URL_UP said
suppressDuplicates=true, then it checked if the map was equal to
the âoldâ map before publishing. But the map was the same object,
and that object had been modified in-place. So the object was
always equal to itself. It therefore never did an emit(), so the
enricher that listened to it to set serviceUp never fired.
commit a2d34d512fc08dff81bb082a1e7bb79a0448680d
Author: Aled Sage <[email protected]>
Date: 2015-09-19T14:52:21Z
Fix UpdatingMap for if suppressDuplicates=true
- log.warn to say it should not be set.
- reset config to suppressDuplicates=false
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
