Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/927#discussion_r41186852
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/VanillaWindowsProcess.java
---
@@ -49,14 +52,34 @@
"indicates that a reboot should be performed after the install
command is run", false);
ConfigKey<Boolean> CUSTOMIZE_REBOOT_REQUIRED =
ConfigKeys.newBooleanConfigKey("customize.reboot.required",
--- End diff --
I'd include `priority=...` on each, to force a sensible order in their
listing within the wizard. Not sure what guarantees we get here (probably it's
just in the order returned by
http://docs.oracle.com/javase/7/docs/api/java/lang/Class.html#getFields(),
which says "not sorted and are not in any particular order").
I personally would have also added `@CatalogConfig` to the other powershell
commands such as `PRE_INSTALL_POWERSHELL_COMMAND` etc. It's easy enough for
someone to scroll down, filling in only what they want. But if they are not
annotated then that config option is very hard to use from the wizard.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
