GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/939
Fix/anonymous inner classes in predicates
Use of anonymous inner classes (or non-static inner classes) makes
persistence very brittle.
Changes our `*Predicates` and `*Functions` to use static inner classes
(keeping the old classes around for backwards compatibility), and adds more
tests for these.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn
fix/anonymous-inner-classes-in-predicates
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/939.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #939
----
commit 6c2f9ded78d63fe8704f96e8c48d3a210492a8da
Author: Aled Sage <[email protected]>
Date: 2015-10-05T19:42:18Z
Not anonymous inner classes in predicates
- Anonymous inner classes makes persistence very brittle.
- Make names more consistent across the different predicates classes
(e.g. ânameSatisfiesâ when passing in a predicate).
- Adds more tests.
commit f7c6147ea9a2d915d5b5ab697361c59b7040e385
Author: Aled Sage <[email protected]>
Date: 2015-10-07T09:20:46Z
Not anonymous inner classes in functions
- Anonymous inner classes makes persistence very brittle.
- Adds more tests.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
