Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/865#discussion_r41522483
  
    --- Diff: usage/jsgui/src/main/license/source-inclusions.yaml ---
    @@ -38,3 +38,5 @@
     - id: js-uri
     - id: js-yaml.js
     - id: jquery.form.js
    +
    +- id: codemirror.js
    --- End diff --
    
    no need to add the codemirror dependencies here, but we do need a 
corresponding entry in `usage/dist/licensing/overrides.yaml` and there under 
`files` list the files pulled in (as done for `jquery.dataTables`) -- it's only 
used to generate the proper license files


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to