Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/955#discussion_r42049984
--- Diff:
core/src/main/java/org/apache/brooklyn/core/plan/PlanToSpecTransformer.java ---
@@ -56,6 +57,6 @@
* implementations will typically look at the {@link
CatalogItem#getCatalogItemType()} first.
* <p>
* should throw {@link PlanNotRecognizedException} if this transformer
does not know what to do with the plan. */
- <T,SpecT extends AbstractBrooklynObjectSpec<? extends T, SpecT>> SpecT
createCatalogSpec(CatalogItem<T, SpecT> item) throws PlanNotRecognizedException;
+ <T,SpecT extends AbstractBrooklynObjectSpec<? extends T, SpecT>> SpecT
createCatalogSpec(CatalogItem<T, SpecT> item, Set<String> encounteredTypes)
throws PlanNotRecognizedException;
--- End diff --
Worth noting in the javadoc how the additional argument should be used by
implementors.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
