Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/959#discussion_r42172681
  
    --- Diff: 
software/webapp/src/main/java/org/apache/brooklyn/entity/webapp/JavaWebAppSshDriver.java
 ---
    @@ -93,11 +93,11 @@ protected String inferRootUrl() {
             if (isProtocolEnabled("https")) {
                 Integer port = getHttpsPort();
                 checkNotNull(port, "HTTPS_PORT sensors not set; is an 
acceptable port available?");
    -            return String.format("https://%s:%s/";, getSubnetHostname(), 
port);
    +            return String.format("https://%s:%s/";, getHostname(), port);
    --- End diff --
    
    @grkvlt will this cause a problem from Clocker?
    
    The problem is it depends on the context for whether you want the subnet 
hostname/ip or the public hostname/ip. We don't know at this point how the 
main.uri sensor is going to be used.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to