GitHub user aledsage opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/977

    BROOKLYN-186 workaround in JcloudsLocation

    Fixes BROOKLYN-186 by working around if jclouds gives us the wrong login 
user, or gives us both a password and ssh key (where only one of them works).
    
    It's a bit messy doing this, but feels like the most robust thing to do.
    
    (The other commit about `MutableSet` is just to make that easier to use in 
my JcloudsLocation fix, and to improve test coverage while I was at it).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/incubator-brooklyn 
fix/jclouds-giving-passwordAndKey

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/977.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #977
    
----
commit ddfb6e29a3df314ab4bc6c4aeefded6d61a4486d
Author: Aled Sage <[email protected]>
Date:   2015-10-20T20:35:35Z

    Adds MutableSet.Builder.addIfNotNull
    
    - And adds MutableList.Builder.addIfNotNull
    - Adds MutableSetTest

commit 6ca7e26748e69365fe2d4d2d5231a3406197f877
Author: Aled Sage <[email protected]>
Date:   2015-10-14T10:19:07Z

    BROOKLYN-186 workaround in JcloudsLocation
    
    If we get back a node with both a password and ssh key, and/or
    if that node has a different user from the overridden loginUser,
    then try all combinations of those credentials to try to login.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to