GitHub user neykov opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/984
Convert Groovy tests to Java
This has been sitting around on my disk for quite some time, better get it
out before we do another mass renaming :)
The changes can be split in three main parts:
* convert groovy tests to their java equivalent, mostly straightforward
* remove deprecated groovy classes and their usages
* reimplement GroovyJavaMethods in plain Java - this is not a natural
conversion but allows to completely get rid of the groovy compiler for the
project
Why is this change useful - in addition to the added static safety we get
from the converted code, it's no longer required to install the groovy plugin
in Eclipse to be able to use the project. Probably most useful to beginners who
can import the project in a plain Eclipse install.
The remaining groovy files (in `core` only) exercise how Brooklyn handles
Groovy objects, doesn't make sense to convert them to Java. Maybe we could move
them to a dedicated project in future.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/incubator-brooklyn groovy-to-java-redo
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/984.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #984
----
commit f69ade37a641e1b1997b71986e8a5731b1dccc59
Author: Svetoslav Neykov <[email protected]>
Date: 2015-10-22T12:48:07Z
Convert groovy tests to java
commit de3b706ed24d69c31752a97a4188215c537d41b9
Author: Svetoslav Neykov <[email protected]>
Date: 2015-07-10T15:14:19Z
Adjuncts shouldn't mutate passed flags
The constructor would mutate the passed in map and even keep reference to
it, modifying it on the next .configure call.
commit 18c28d24f1e0828ee1064b32da3840822ee21f2c
Author: Svetoslav Neykov <[email protected]>
Date: 2015-07-10T15:15:34Z
Remove deprecated and unused groovy code
commit 0d0214ccecc6222ffa7c712b1b9077c9356f6f46
Author: Svetoslav Neykov <[email protected]>
Date: 2015-10-22T06:49:22Z
Reimplement GroovyJavaMethods in Java
commit 4ba22be8457bad0ebb1472aae6216ba689a34c31
Author: Svetoslav Neykov <[email protected]>
Date: 2015-10-22T06:49:37Z
Remove groovy dependencies
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
