Github user hzbarcea commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/962#issuecomment-150883102
  
    @CMoH , I don't know why Jenkins failed, from a cursory look at the output 
logs it shouldn't have happened. Something to investigate.
    
    Tests look ok and a quick look at the changes also looks ok. I also tested 
with a clean .m2 repository with no problems. I will spend a good part of 
tomorrow reviewing carefully your changes and test for regression issues. This 
is a big change and we should be careful with merging. I would think that we 
should try to merge this sooner and continue testing and fix regression issues 
until 0.9.0, but I am curious what others think too. Extra pairs of eyes would 
be extremely helpful.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to