Github user googlielmo commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1000#discussion_r43911237
  
    --- Diff: 
usage/rest-client/src/main/java/org/apache/brooklyn/rest/client/BrooklynApi.java
 ---
    @@ -114,11 +150,23 @@ public BrooklynApi(String endpoint, @Nullable 
Credentials credentials) {
             }
         }
     
    +    /**
    +     * @deprecated since 0.9.0. Use {@link 
BrooklynApiFactory#getBrooklynApi(java.net.URL, String, String)} instead
    +     * @see org.apache.brooklyn.rest.client.DefaultBrooklynApiFactory
    +     * @see org.apache.brooklyn.rest.client.PoolingBrooklynApiFactory
    +     */
    +    @Deprecated
    --- End diff --
    
    Then probably it's best to reinstate the previous public constructor and 
remove the new one. The subclassing is certainly too complicated, especially if 
we don't follow the factory route.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to