Much more concise, +1 On Mon, 9 Nov 2015 at 09:33 Mark McKenna <[email protected]> wrote:
> +1 > > On Fri, 6 Nov 2015, 16:51 Svetoslav Neykov < > [email protected]> wrote: > > > Hi devs, > > > > I propose that we change the rules for creating a wapper application for > > CAMP plans. There's an unexpected side effect presently where pointing > to a > > catalog item and giving a top-level name to the plan will prevent > > unwrapping. It's surprising to users and even more so because it wasn't > the > > case a few months ago. > > > > For example the following catalog item: > > > > brooklyn.catalog: > > id: simpleApp > > version: 1.0 > > displayName: Simple App > > itemType: template > > item: > > services: > > - type: my-simple-app > > > > when started in the Application Wizard and given a name, equivalent to > the > > following plan: > > > > name: My App > > services: > > - type: "simpleApp:1.0" > > > > will result in this hierarchy: > > > > * My App (BasicApplication) > > * Simple App (my-simple-app) > > > > I propose that we change the logic such that the root level name will > > overwrite the child's name, so the hierarchy becomes: > > > > * My App (my-simple-app) > > > > > > There's a PR opened for this change at > > https://github.com/apache/incubator-brooklyn/pull/1007. > > > > Svet. > > > > > > >
