Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1013#discussion_r44434315
  
    --- Diff: 
core/src/main/java/org/apache/brooklyn/util/core/internal/ssh/SshTool.java ---
    @@ -49,7 +50,14 @@
          * These keys are detected from entity/global config and automatically 
applied to ssh executions. */
         public static final String BROOKLYN_CONFIG_KEY_PREFIX = 
"brooklyn.ssh.config.";
         
    -    public static final ConfigKey<String> PROP_TOOL_CLASS = 
newStringConfigKey("tool.class", "SshTool implementation to use", null);
    +    /**
    +     * @deprecated since 0.9.0; use {@link 
SshMachineLocation#SSH_TOOL_CLASS}
    +     */
    +    @Deprecated
    +    public static final ConfigKey<String> PROP_TOOL_CLASS = 
newStringConfigKey(
    --- End diff --
    
    agree wtih @bostko about pattern where we share the static config key 
definition; but this particular key name is horrible so +1 to the deprecation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to