Github user rdowner commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1018#discussion_r44523173
  
    --- Diff: 
core/src/main/java/org/apache/brooklyn/core/mgmt/internal/AbstractManagementContext.java
 ---
    @@ -372,6 +377,27 @@ public BrooklynProperties getBrooklynProperties() {
             return configMap;
         }
     
    +    public StringConfigMap getConfigWithExternalConfigResolved() {
    +        final ExternalConfigSupplierRegistry 
externalConfigProviderRegistry = getExternalConfigProviderRegistry();
    +        if (externalConfigProviderRegistry == null)
    +            return configMap; // no external config available yet, so 
return config without resolving
    --- End diff --
    
    This check is probably superfluous. It was required in an earlier iteration 
of this code where the constructor had possibly not finished, but that should 
not be the case now. I will either remove it, or (to be safe) make it throw an 
`IllegalStateException`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to