Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1017#discussion_r44548903
--- Diff:
core/src/main/java/org/apache/brooklyn/core/plan/PlanToSpecFactory.java ---
@@ -36,12 +40,30 @@
import com.google.common.base.Function;
import com.google.common.collect.ImmutableList;
+/** @deprecated since 0.9.0 use {@link TypePlanTransformers} as part of
switch to {@link BrooklynTypePlanTransformer};
+ * mark transformers as deprecated if there is a preferred corresponding
{@link BrooklynTypePlanTransformer} */
+@Deprecated
public class PlanToSpecFactory {
private static final Logger log =
LoggerFactory.getLogger(PlanToSpecFactory.class);
- private static Collection<PlanToSpecTransformer> getAll() {
- return
ImmutableList.copyOf(ServiceLoader.load(PlanToSpecTransformer.class));
+ private static Collection<PlanToSpecTransformer> getAll(boolean
includeDeprecated) {
--- End diff --
The `includeDeprecated` filter doesn't have good vibes :). It's all in
deprecated functionality so no big deal, but still hope it doesn't stick for
too long.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
