Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1017#discussion_r44651468
--- Diff:
core/src/test/java/org/apache/brooklyn/core/catalog/internal/TestToSpecTransformer.java
---
@@ -20,43 +20,36 @@
import java.util.Map;
import java.util.Set;
-import java.util.concurrent.ConcurrentHashMap;
+import org.apache.brooklyn.api.catalog.BrooklynCatalog;
import org.apache.brooklyn.api.catalog.CatalogItem;
import org.apache.brooklyn.api.entity.Application;
import org.apache.brooklyn.api.entity.EntitySpec;
import org.apache.brooklyn.api.internal.AbstractBrooklynObjectSpec;
import org.apache.brooklyn.api.mgmt.ManagementContext;
+import org.apache.brooklyn.api.typereg.RegisteredType;
import org.apache.brooklyn.core.plan.PlanNotRecognizedException;
import org.apache.brooklyn.core.plan.PlanToSpecTransformer;
-import org.apache.brooklyn.util.text.Identifiers;
+import org.apache.brooklyn.core.typereg.JavaClassNameTypePlanTransformer;
+import org.apache.brooklyn.core.typereg.RegisteredTypeLoadingContexts;
+import org.apache.brooklyn.util.collections.MutableSet;
import org.apache.brooklyn.util.yaml.Yamls;
+import com.google.common.collect.Iterables;
+
/**
- * Resolves previously registered specs by id.
- * First create a spec and register it, keeping the returned ID:
- * <pre> {@code
- * String specId =
TestToSpecTransformer.registerSpec(EntitySpec.create(BasicEntity.class));
- * }</pre>
- *
- * Then build a plan to be resolved such as:
- * <pre> {@code
- * brooklyn.catalog:
- * id: test.inputs
- * version: 0.0.1
- * item: <specId>
- * } </pre>
+ * For use in conjunction with {@link StaticTypePlanTransformer};
+ * this will lookup an item by ID or in a map "type: id".
+ * <p>
+ * Should be removed when catalog is able to function using new-style
lookups.
*/
public class TestToSpecTransformer implements PlanToSpecTransformer {
--- End diff --
Still can't wrap my head around the changes in this file.
`StaticTypePlanTransformer` doesn't seem to be involved at all where this is
used.
Looks like it's just a minimalistic CAMP parser, delegating to the registry
to resolve the type. It's used in a single test - not worth it's weight
(especially implementing deprecated functionality).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
