Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1017#discussion_r44662144
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/text/Identifiers.java ---
@@ -26,6 +26,9 @@
public static final String JAVA_GOOD_START_CHARS =
"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz_";
public static final String JAVA_GOOD_NONSTART_CHARS =
JAVA_GOOD_START_CHARS+"1234567890";
+ public static final String JAVA_SEGMENT_REGEX =
"["+JAVA_GOOD_START_CHARS+"]"+"["+JAVA_GOOD_NONSTART_CHARS+"]*";
+ public static final String JAVA_PACKAGE_OR_CLASS_REGEX =
"("+JAVA_SEGMENT_REGEX+"\\."+")*"+JAVA_SEGMENT_REGEX;
+ public static final String JAVA_BINARY_REGEX =
JAVA_PACKAGE_OR_CLASS_REGEX+"(\\$["+JAVA_GOOD_NONSTART_CHARS+"]+)*";
--- End diff --
This includes a tiny subset of valid java identifiers, see
http://docs.oracle.com/javase/specs/jls/se7/html/jls-3.html#jls-3.8. Could lead
to subtle bugs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
