Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1038#discussion_r45187377
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -3004,6 +3006,14 @@ protected static double toDouble(Object v) {
}
}
+ protected static int[] toIntPortArray(Object v) {
+ Collection<String> inboundPortEntries = toListOfStrings(v);
--- End diff --
Not fully backwards compatible. `toIntArray` supports the format `[1,2,3]`.
Also accepts int arrays if passed from Java code. The first one should
definitely be supported, no hard opinion on the second one.
Would be nice to have a test for the new method.
Otherwise looks very useful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
