[
https://issues.apache.org/jira/browse/BROOKLYN-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15012354#comment-15012354
]
ASF GitHub Bot commented on BROOKLYN-185:
-----------------------------------------
Github user hzbarcea commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1040#issuecomment-157897657
Reviewed. Looks good.
One minor comment is that the "@author" tags are discouraged, as in time
they tend to not reflect the collaborative reality. They are everywhere, so at
some point we should probably get rid of them, like many other projects did.
Not a priority.
> Upgrade swagger to 1.5.3
> ------------------------
>
> Key: BROOKLYN-185
> URL: https://issues.apache.org/jira/browse/BROOKLYN-185
> Project: Brooklyn
> Issue Type: Improvement
> Affects Versions: 0.8.0
> Reporter: Ciprian Ciubotariu
> Assignee: Ciprian Ciubotariu
> Fix For: 0.9.0
>
>
> Brooklyn is now using swagger version 1.0.1, based on scala 2.9.1. The
> current stable version is 1.5.3, which no longer depends on scala, while
> version 1.0.1 is deprecated.
> More at https://github.com/swagger-api/swagger-core#compatibility
> Version 1.0.1 is a blocker for BROOKLYN-183, since the respective versions of
> swagger and scala are not bundled for OSGi, while swagger-1.5.3 has the
> appropriate OSGi manifest attributes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
