Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1039#issuecomment-158084316
Thanks for the quick responses @tbouron, @nakomis. I still think that you
should create a spec out of the catalog item and use the java type from there.
You are essentially replicating the same logic, but doing it ad-hoc. Just a
couple of examples where it would fail - any references to the newly introduced
type registry won't be handled properly; there are various key words to specify
the service type (type, serviceType, service_type).
As for the eager vs lazy evaluation a valid case where it would change is
if I it's depeneding on the catalog item `tomcat-server` and a new version of
the catalog item is introduced, implementing a new interface. This won't get
reflected in all catalog items using it. I agree it's a matter of personal
opinion to some extent (weighting pros and cons of eagor vs lazy) so I can
agree to the current approach as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
