Github user johnmccabe commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1031#discussion_r45367667
  
    --- Diff: 
docs/guide/yaml/test/example_yaml/testcases/getting-started-test-example.yaml 
---
    @@ -0,0 +1,68 @@
    +name: Getting Started Blueprint Test
    +
    +location:
    +  jclouds:aws-ec2:
    +    identity: ABCDEFGHIJKLMNOPQRST
    +    credential: s3cr3tsq1rr3ls3cr3tsq1rr3ls3cr3tsq1rr3l
    +
    +services:
    +- type: org.apache.brooklyn.entity.webapp.ControlledDynamicWebAppCluster
    +  name: My Web
    +  id: webappcluster
    +  brooklyn.config:
    +    wars.root: 
http://search.maven.org/remotecontent?filepath=io/brooklyn/example/brooklyn-example-hello-world-sql-webapp/0.6.0/brooklyn-example-hello-world-sql-webapp-0.6.0.war
    +    java.sysprops:
    +      brooklyn.example.db.url: >
    +        $brooklyn:formatString("jdbc:%s%s?user=%s&password=%s",
    +        component("db").attributeWhenReady("datastore.url"),
    +        "visitors", "brooklyn", "br00k11n")
    +- type: org.apache.brooklyn.entity.database.mysql.MySqlNode
    +  id: db
    +  name: My DB
    +  brooklyn.config:
    +    creationScriptUrl: https://bit.ly/brooklyn-visitors-creation-script
    +- type: org.apache.brooklyn.test.framework.TestHttpCall
    +  name: Check HTTP Response Status Code
    +  url: >
    +    $brooklyn:formatString("http://%s:%s";,
    --- End diff --
    
    We do, but its current being assigned a non-public address for the 
NginxController (on SL), I would have expected the webapp.url to be a public 
address (per the change in #959), had only spotted this last night and have not 
gotten round to raising it - will do so now - wanted to make sure the examples 
would be functional in the immediate term so pushed in this workaround.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to