Github user mikezaccardo commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1050#issuecomment-158578735
Thanks for reviewing, @sjcorbett. You're definitely right about the `null`
case in my `FALSE` comparison -- I've switched to checking `!TRUE`.
As for your other comments, I think I need to elaborate on my intended use
for this sensor; perhaps it is not properly named. I want to be able to use
this as a launch latch / attribute when ready sensor.
If the emptiness check is removed then this sensor will resolve to true
immediately when the cluster is created (before the children are added) which
is too early. I could remove this check but then I'd need to leave in the
check for the running lifecycle state -- that way even though the cluster is
empty in the beginning, this sensor would not resolve to true because it is not
yet running at that point.
tl;dr -- I need one or both of the checks that you flagged to remain in
order for the sensor to behave the way I'd like it to. WDYT?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
