Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1063#discussion_r45793598
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/BrooklynTags.java ---
@@ -51,9 +56,59 @@ public String getContents() {
return contents;
}
}
-
- public static NamedStringTag newYamlSpecTag(String contents) { return
new NamedStringTag(YAML_SPEC_KIND, contents); }
- public static NamedStringTag newNotesTag(String contents) { return new
NamedStringTag(NOTES_KIND, contents); }
+
+ public static class ListTag<T> {
--- End diff --
I think we shouldn't reuse this, if there are multiple items each should be
inserted in a separate tag (i.e. have flat tags). How does adding a trait look
like with this type of tag? Should it be inserted in a new collection of
traits? Just thinking out loud.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
