Github user CMoH commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1048#discussion_r45798003
  
    --- Diff: usage/rest-server/pom.xml ---
    @@ -241,9 +241,46 @@
                     <!-- Required to set values in build-metadata.properties 
-->
                     <filtering>true</filtering>
                 </resource>
    +            <resource>
    +                <directory>${basedir}/src/main/webapp</directory>
    +            </resource>
             </resources>
             <plugins>
     
    +            <plugin>
    +                <groupId>org.apache.felix</groupId>
    +                <artifactId>maven-bundle-plugin</artifactId>
    +                <extensions>true</extensions>
    +                <!-- configure plugin to generate MANIFEST.MF
    +                     adapted from 
http://blog.knowhowlab.org/2010/06/osgi-tutorial-from-project-structure-to.html 
-->
    +                <executions>
    +                    <execution>
    +                        <id>bundle-manifest</id>
    +                        <phase>process-classes</phase>
    +                        <goals>
    +                            <goal>manifest</goal>
    +                        </goals>
    +                    </execution>
    +                </executions>
    +                <configuration>
    +                    <supportedProjectTypes>
    +                        <supportedProjectType>jar</supportedProjectType>
    +                    </supportedProjectTypes>
    +                    <instructions>
    +                        <Import-Package>
    +                            
com.sun.jersey.spi.container.servlet;version="[1.18.1,2.0)",
    +                            *
    +                        </Import-Package>
    +                        
<Export-Package>org.apache.brooklyn.*</Export-Package>
    +                        
<Implementation-SHA-1>${buildNumber}</Implementation-SHA-1>
    +                        
<Implementation-Branch>${scmBranch}</Implementation-Branch>
    --- End diff --
    
    Yes, they are indeed. However, I plan to revisit each pom regarding 
maven-bundle-plugin, so I slacked a bit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to