Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1062#issuecomment-159551759
Thanks @sjcorbett @ahgittin
Agree with the mid-term aims. It's tricky just now to safely just turn off
jmx/http entirely in a super-class, as it depends on the entity for whether
that contributes towards service-up or if it's just for usage/performance
metrics.
For singling out `MongoDBServer` (versus `MongoDBRouter` and
`MongoDBConfigServer`), that is a simple one to get working when there is only
ssh access. If there is no replica set, then it's easy. For the methods I
guarded (`initializeReplicaSet`, `addMemberToReplicaSet` and
`removeMemberFromReplicaSet`) they are called by `MongoDBReplicaSetImpl`. It's
hard to tell in `MongoDBServerImpl.init` if it's going to be in a replica set
or stand-alone. We could try to look at the parent entity, but that seems
inelegant. If you're ok with it, then I suggest leaving as-is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
