Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1070#discussion_r46031229
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/collections/CollectionFunctionals.java
---
@@ -107,12 +107,12 @@ public Integer apply(Iterable<?> input) {
}
public static final class FirstElementFunction<T> implements
Function<Iterable<? extends T>, T> {
- private FirstElementFunction() {
+ public FirstElementFunction() {
--- End diff --
is this needed? we have a static method
`CollectionFunctionals.firstElement()` to return the instance, and the class is
`final` so you can't subclass so i'm not sure what benefit there is from making
this public. (a javadoc on the constructor pointing at the method could be
useful though!)
no strong feelings though
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
