Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1066#discussion_r46173608
--- Diff:
usage/test-framework/src/main/java/org/apache/brooklyn/test/framework/TestFrameworkAssertions.java
---
@@ -39,122 +42,216 @@
* @author m4rkmckenna on 11/11/2015.
*/
public class TestFrameworkAssertions {
- private static final Logger LOG =
LoggerFactory.getLogger(TestFrameworkAssertions.class);
+
+ public static final String IS_NULL = "isNull";
+ public static final String NOT_NULL = "notNull";
+ public static final String IS_EQUAL_TO = "isEqualTo";
--- End diff --
I have a personal preference of not supporting lots of variants. It feels
nice sometimes, but then when someone starts looking at different examples and
sees different text in each, it looks confusing (*). But no strong feelings.
(*) there are exceptions to that, such as in Duration where we accept `1h`
and `1hr` etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
