yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r267283363
########## File path: src/brpc/socket.cpp ########## @@ -1523,7 +1523,7 @@ int Socket::Write(butil::IOBuf* data, const WriteOptions* options_in) { if (options_in) { opt = *options_in; } - if (data->empty()) { + if (data->empty() && opt.with_auth == false) { Review comment: 因为mysql的鉴权是首先得先收一个消息,然后再发起鉴权,再发送正常请求,所以第一次write我需要把正常请求保存起来,这样我调用write传入的就是个空消息。 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org