kevinis commented on a change in pull request #878: Use prebuilt MesaLink
package in travis CI
URL: https://github.com/apache/incubator-brpc/pull/878#discussion_r312161146
##########
File path: CMakeLists.txt
##########
@@ -167,6 +182,7 @@ set(DYNAMIC_LIB
${THRIFTNB_LIB}
${OPENSSL_LIBRARIES}
${OPENSSL_CRYPTO_LIBRARY}
+ ${MESALINK_LIB}
Review comment:
MesaLink provides SSL/TLS but not crypto; so OpenSSL's libcrypto is still
linked.
Actually, either `${OPENSSL_LIBRARIES}` or `${OPENSSL_SSL_LIBRARY}` is just
redundant in the cases of MesaLink builds. No code uses libssl; therefore the
generated libbrpc.so does not link libssl.
```shell
ldd output/lib/libbrpc.so
```
yields the following result:
https://paste.ubuntu.com/p/bCMkRJyFK9/
So you can see there's no libssl linked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
