jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r349555128
##########
File path: src/brpc/redis.h
##########
@@ -209,6 +209,44 @@ class RedisResponse : public ::google::protobuf::Message {
std::ostream& operator<<(std::ostream& os, const RedisRequest&);
std::ostream& operator<<(std::ostream& os, const RedisResponse&);
+enum RedisCommandResult {
Review comment:
这个前缀容易和client端的command混淆起来，"Handler"是省不了的。也可以把它放在下面的RedisCommandHandler里，名字叫Result，这样用起来就是RedisCommandHandler::Result了。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
