jamesge commented on a change in pull request #972: Redis server protocol URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r355397364
########## File path: src/brpc/redis_reply.h ########## @@ -160,6 +212,87 @@ inline int64_t RedisReply::integer() const { return 0; } +inline bool RedisReply::SetNilString() { + if (!_arena || _has_set) return false; + _type = REDIS_REPLY_STRING; + _length = npos; + _has_set = true; + return true; +} + +inline bool RedisReply::SetArray(int size) { Review comment: 这么长也inline? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org