cloudhan opened a new issue #1023: Please stop using include(FindXXX) in cmake URL: https://github.com/apache/incubator-brpc/issues/1023 ```cmake include(FindProtobuf) include(FindThreads) ``` In practice they should be ```cmake find_package(Protobuf REQUIRED) find_package(Threads REQUIRED) ``` these include thing caused many integration problem. `find_package` have many special handling of search path, which will let users have fine-grind control over where to find the package.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
