jamesge commented on a change in pull request #1128:
URL: https://github.com/apache/incubator-brpc/pull/1128#discussion_r433104470
##########
File path: src/brpc/policy/redis_protocol.cpp
##########
@@ -76,7 +76,7 @@ class RedisConnContext : public Destroyable {
};
int ConsumeCommand(RedisConnContext* ctx,
- const std::vector<const char*>& commands,
+ const std::vector<butil::StringPiece>& commands,
Review comment:
这是args还是commands？
##########
File path: src/brpc/policy/redis_protocol.cpp
##########
@@ -90,10 +90,10 @@ int ConsumeCommand(RedisConnContext* ctx,
return -1;
}
} else {
- RedisCommandHandler* ch =
ctx->redis_service->FindCommandHandler(commands[0]);
+ RedisCommandHandler* ch =
ctx->redis_service->FindCommandHandler(commands[0].as_string());
Review comment:
FindCommandHandler的参数可以改成StringPiece？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
