jamesge commented on a change in pull request #1161: URL: https://github.com/apache/incubator-brpc/pull/1161#discussion_r454811965
########## File path: src/brpc/channel.cpp ########## @@ -476,7 +480,6 @@ void Channel::CallMethod(const google::protobuf::MethodDescriptor* method, // parameters in `cntl' are set. Review comment: 这两个分支判断重复了,需要保留一个且移动到_serialize_request后。 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org