wwbmmm commented on a change in pull request #1690:
URL: https://github.com/apache/incubator-brpc/pull/1690#discussion_r806653959
##########
File path: test/brpc_http_rpc_protocol_unittest.cpp
##########
@@ -310,6 +325,12 @@ TEST_F(HttpTest, verify_request) {
VerifyMessage(msg, false);
msg->Destroy();
}
+ {
+ brpc::policy::HttpContext* msg =
+ MakePostProtoTextRequestMessage("/EchoService/Echo");
+ VerifyMessage(msg, false);
+ msg->Destroy();
Review comment:
I seems that this unit test does not cover any code you change in
`http_rpc_protocol.cpp`. You can reference the unit test named
`spring_protobuf_content_type` in `brpc_http_rpc_protocol_unittest.cpp` which
also test a new content type.
##########
File path: test/brpc_http_rpc_protocol_unittest.cpp
##########
@@ -310,6 +325,12 @@ TEST_F(HttpTest, verify_request) {
VerifyMessage(msg, false);
msg->Destroy();
}
+ {
+ brpc::policy::HttpContext* msg =
+ MakePostProtoTextRequestMessage("/EchoService/Echo");
+ VerifyMessage(msg, false);
+ msg->Destroy();
Review comment:
It seems that this unit test does not cover any code you change in
`http_rpc_protocol.cpp`. You can reference the unit test named
`spring_protobuf_content_type` in `brpc_http_rpc_protocol_unittest.cpp` which
also test for a new content type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
