+1(non-binding) I checked:
Checklist for reference: [x] Download links are valid. [x] Checksums and PGP signatures are valid. [x] Source code distributions have correct names matching the current release. [x] LICENSE and NOTICE files are correct for each brpc repo. [x] All files have license headers if necessary. [x] No compiled archives bundled in source archive. Best Regards, Guodong On Tue, Jul 12, 2022 at 4:30 PM Hu go <uestc.h...@gmail.com> wrote: > +1 (non-binding) > > I have checked: > [x] Download links are valid. > [x] incubating in the name. > [x] Checksums and GPG signatures are valid. > [x] RELEASE_VERSION in the source code matches the current release. > [x] LICENSE and NOTICE files are correct for each brpc repo. > [x] No compiled archives bundled in the source archive. > [x] Compiled successfully on macbook pro m1 chip, monterey 12.0.1 > > Best Regards, > Xiguo > > On Mon, Jul 11, 2022 at 7:42 PM Xiaofeng <wasp...@gmail.com> wrote: > > > +1 (non-binding) > > > > I have checked: > > [x] Download links are valid. > > [x] incubating in the name. > > [x] Checksums and GPG signatures are valid. > > [x] RELEASE_VERSION in the source code matches the current release. > > [x] LICENSE and NOTICE files are correct for each brpc repo. > > [x] No compiled archives bundled in the source archive. > > > > Best Regards, > > Xiaofeng > > > > On Mon, Jul 11, 2022 at 4:42 PM Weibing Wang <wwb...@apache.org> wrote: > > > > > > +1 (binding) > > > > > > I have checked: > > > > > > [x] Download links are valid. > > > [x] Checksums and GPG signatures are valid. > > > [x] Source code distributions have correct names matching the current > > > release. > > > [x] LICENSE and NOTICE files are correct for each brpc repo. > > > [x] No compiled archives bundled in source archive. > > > > > > Best Regards, > > > Weibing > > > > > > On Mon, Jul 11, 2022 at 3:46 PM Shuai Liu <serverg...@gmail.com> > wrote: > > > > > > > > Hello Apache brpc (Incubating) Community, > > > > > > > > This is a call for vote to release Apache brpc (Incubating) version > > > > 1.2.0 > > > > > > > > [Release Note] > > > > - Support apple silicon by @jamesge > > > > - Add an option to allow serialize/deserialize to/from a json > array > > by > > > > @wasphin in #1604 > > > > - Add redis empty request check by @lzfhust in #1745 > > > > - Add butex_wake_all support nosignal flag by @yanglimingcn in > #1751 > > > > - Add wr/wrr policy degradation by @Huixxi in #1571 > > > > - Add with_snappy in cmake by @renzhong in #1799 > > > > - Add check append return code by @wwbmmm in #1762 > > > > - Add CXXFLAGS in compiling protoc-gen-mcpack by @jamesge > > > > - Fix the header guard of brpc/periodic_task.h by @TousakaRin in > > #1820 > > > > - Fix build warning, ByteSize() is deprecated, use ByteSizeLong() > > > > instead by @yangzhg in #1723 > > > > - Fix c struct compile error by @wolfdan666 in #1736 > > > > - Fix auto https check by @renzhong in #1754 > > > > - Fix json2pb::JsonToProtoMessage() supports parsing multiple > jsons > > by > > > > @jamesge > > > > - Fix compile error due to std limits header absent by @GOGOYAO in > > #1764 > > > > - Fix a deadlock happened in ClearAbandonedStreamsImpl path by > > @zyearn > > > > in #1781 > > > > - Fix send WindowUpdate when ClearAbandonedStreams is called by > > @zyear > > > > in #1786 > > > > - Fix _dl_sym undefined reference by @wwbmmm in #1784 > > > > - Fix thrift protocol exception by @lzfhust in #1790 > > > > - Fix Brpc build tools error when only build static by @stdpain in > > #1797 > > > > - Fix discovery naming service core by @serverglen in #1802 > > > > - Fix rpc_press can't send request equably by @bumingchun #1763 > > > > - Fix hostname2ip fails when aux_buf is not long enough by > > @chenBright > > > > in #1818 > > > > - Improve documents by @wwbmmm, @tanzhongyi003, @guodongxiaren, > > > > @372046933, @wasphin, @hawkxiang, @TousakaRin, @Huixxi, @serverglen > > > > - Fix typos by @jamesge, @cyberkillor > > > > > > > > The release candidates: > > > > https://dist.apache.org/repos/dist/dev/incubator/brpc/1.2.0/ > > > > > > > > Git tag for the release: > > > > https://github.com/apache/incubator-brpc/releases/tag/1.2.0 > > > > > > > > Release Commit ID: > > > > > > > > > https://github.com/apache/incubator-brpc/commit/29491107cbf405a494aaf80ee32344ba34e1d7e4 > > > > > > > > Keys to verify the Release Candidate: > > > > https://dist.apache.org/repos/dist/dev/incubator/brpc/KEYS > > > > > > > > The vote will be open for at least 72 hours or until necessary number > > of > > > > votes are reached. > > > > > > > > Please vote accordingly: > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove with the reason > > > > > > > > PMC vote is +1 binding, all others is +1 non-binding. > > > > > > > > Checklist for reference: > > > > [ ] Download links are valid. > > > > [ ] Checksums and PGP signatures are valid. > > > > [ ] Source code distributions have correct names matching the current > > > > release. > > > > [ ] LICENSE and NOTICE files are correct for each brpc repo. > > > > [ ] All files have license headers if necessary. > > > > [ ] No compiled archives bundled in source archive. > > > > > > > > Warm Regards, > > > > serverglen > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > > > For additional commands, e-mail: dev-h...@brpc.apache.org > > >
