zyearn commented on PR #1814: URL: https://github.com/apache/incubator-brpc/pull/1814#issuecomment-1190187640
> 不管是来自于[SocketMap](https://github.com/apache/incubator-brpc/blob/master/src/brpc/socket_map.cpp#L247)还是selective_channel中的[_chan_map](https://github.com/apache/incubator-brpc/blob/master/src/brpc/selective_channel.cpp#L206)，健康检查机制关注的还是引用。将_is_in_socket_map改成_is_hc_related_ref_held，是不是更合适一点？_is_hc_related_ref_held表示外部持有了一个与健康检查机制有关的引用，持有该引用的一部分作用是让健康检查机制正常执行。这样就不会与SocketMap耦合了，在selective_channel中变成设置_is_hc_related_ref_held也自然多了。 好的，这个名字可以。另外可以检查一下其它combo channel有没有类似的问题？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
