jenrryyou commented on code in PR #1854:
URL: https://github.com/apache/incubator-brpc/pull/1854#discussion_r943204208
##########
src/brpc/server.h:
##########
@@ -241,6 +241,10 @@ struct ServerOptions {
// Default: NULL (disabled)
RedisService* redis_service;
+ // Optional name for composing server bvar prefix. Read ServerPrefix()
method for details;
+ // Default: ""
+ std::string name;
Review Comment:
> 感觉name有点通用，要不换个名字？比如：server_info_name，或者server_bvar_name。
本意是指用户传入的Server唯一标识(取代Port这种网络领域的标识)。不过name确实太通用，而且容易和service_name混淆。bvar_name又太具体了，这个标识以后也有其他的作用（例如日志打印）。要不改成customized_tag/customized_label代表用户传入的Server标识？server_info_name也可以，看看你觉得哪个更好。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
