wwbmmm commented on issue #1940: URL: https://github.com/apache/incubator-brpc/issues/1940#issuecomment-1278690518
> We could > > * A: check if service name a valid host for HTTP > * B: set host field by remote_side > > option B would revert some changes [dab62e4](https://github.com/apache/incubator-brpc/commit/dab62e476d7dae7edd43d2c9bfa16b76d3ac4879) by @guodongxiaren I think we can check if ns_url shceme is 'http' or 'https', if true, set host field by service_name -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
