cdjingit commented on code in PR #2102:
URL: https://github.com/apache/brpc/pull/2102#discussion_r1092736195


##########
src/brpc/details/ssl_helper.cpp:
##########
@@ -833,6 +874,23 @@ void Print(std::ostream& os, X509* cert, const char* sep) {
     os << butil::StringPiece(bufp, len);
 }
 
+std::string ALPNProtocolToString(const AdaptiveProtocolType& protocol) {
+    std::string name = protocol.name();

Review Comment:
   用butil::StringPiece 
   ```
   butil::StringPiece name(protocol.name());
   if (name.starts_with("http")) {
       name.set("http/1.1");
   }
   ....



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org

Reply via email to