wasphin commented on code in PR #2137:
URL: https://github.com/apache/brpc/pull/2137#discussion_r1118117894
##########
src/brpc/server.cpp:
##########
@@ -451,6 +453,10 @@ Server::~Server() {
delete _options.auth;
_options.auth = NULL;
}
+ if (_options.interceptor) {
Review Comment:
`server_owns_interceptor`?
##########
src/brpc/policy/baidu_rpc_protocol.cpp:
##########
@@ -309,6 +309,22 @@ void EndRunningCallMethodInPool(
return EndRunningUserCodeInPool(CallMethodInBackupThread, args);
};
+// Returns true if accept request, reject request otherwise.
+bool AcceptRequest(const Server* server, Controller* cntl) {
Review Comment:
我看这个函数在多个地方都使用到了, 是不是可以直接声明在头文件中?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
