yockie opened a new pull request, #2328: URL: https://github.com/apache/brpc/pull/2328
### What problem does this PR solve? 1.我们的场景希望将响应时间减少到最小,所以希望将一些类似数据上报的耗时操作(是的,特别耗时)放在response返回之后、request/response析构之前做 2.本pr借鉴了 https://github.com/apache/brpc/pull/1433,看这个pr一直没合入且测试发现有些问题&不太满足我们的需要,所以另提一个,https://github.com/apache/brpc/pull/1433 的问题主要是: (1)太多无关topic的改动 (2)仅在SendRpcResponse成功时才调用call_after_rpc_resp函数,失败时没有调用(我们需要无论成功或失败都要调用) (3)定义的after_resp_fn_t不包含controller指针,我们需要拿到controller对象(进而拿到session data指针,所以声明为非const指针) 3.同样在目前在常用的 baidu_std/http/http2 协议上支持。其他协议未开发。 4.将Controller与req、res的析构顺序进行了修改,依赖关系应该是controller依赖req、res,所以应该先析构controller,后析构req、res 麻烦maintainers看看有什么不妥之处~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
