+1 (binding). I have checked: [x] Download links are valid. [x] Checksums and PGP signatures are valid. [x] Source code distributions have correct names matching the current release. [x] LICENSE and NOTICE files are correct for each brpc repo. [x] All files have license headers if necessary. [x] No compiled archives bundled in source archive.
On Mon, 31 Jul 2023 at 04:50, Lorin Lee <lorinlee1...@gmail.com> wrote: > +1 (binding) > > I have checked: > [x] Download links are valid. > [x] Checksums and PGP signatures are valid. > [x] Source code distributions have correct names matching the current > release. > [x] LICENSE and NOTICE files are correct for each brpc repo. > [x] All files have license headers if necessary. > [x] No compiled archives bundled in source archive. > > > Best Regards, > Lorin Lee > > Wang,Weibing <wwb...@gmail.com> 于2023年7月26日周三 10:59写道： > > > + 1 (binding) > > > > I have checked: > > [x] Download links are valid. > > [x] Checksums and PGP signatures are valid. > > [x] Source code distributions have correct names matching the current > > release. > > [x] LICENSE and NOTICE files are correct for each brpc repo. > > [x] All files have license headers if necessary. > > [x] No compiled archives bundled in source archive. > > > > Best regards > > Weibing > > > > On Mon, Jul 24, 2023 at 8:54 PM Guangming Chen <guangmingc...@apache.org > > > > wrote: > > > > > > +1 non-binding > > > > > > I have checked: > > > [x] Download links are valid. > > > [x] Checksums and PGP signatures are valid. > > > [x] Source code distributions have correct names matching the current > > release. > > > [x] LICENSE and NOTICE files are correct for each brpc repo. > > > [x] All files have license headers if necessary. > > > [x] No compiled archives bundled in source archive. > > > > > > On 2023/07/24 12:02:56 Shuai Liu wrote: > > > > +1 non-binding > > > > > > > > I have checked: > > > > [x] Download links are valid. > > > > [x] Checksums and PGP signatures are valid. > > > > [x] Source code distributions have correct names matching the current > > release. > > > > [x] LICENSE and NOTICE files are correct for each brpc repo. > > > > [x] All files have license headers if necessary. > > > > [x] No compiled archives bundled in source archive. > > > > > > > > > > > > Best Regards, > > > > serverglen > > > > > > > > Wang Xiaofeng <xiaof...@apache.org> 于2023年7月24日周一 13:41写道： > > > > > > > > > > +1 non-binding > > > > > > > > > > I have checked: > > > > > - [x] the links of the package are valid; > > > > > - [x] the checksum of the package is valid; > > > > > - [x] the signature of the package is valid; > > > > > - [x] RELEASE_VERSION in the source code matches the current > release; > > > > > - [x] no compiled archives bundled in the source archive. > > > > > > > > > > Note that, Apache bRPC is not compatible with protobuf >= v22, > which > > introduced a breaking change [1], [2]. > > > > > > > > > > - [1] > https://github.com/protocolbuffers/protobuf/releases/tag/v22.0 > > > > > - [2] https://github.com/protocolbuffers/protobuf/pull/10416 > > > > > > > > > > Regards, > > > > > Xiaofeng > > > > > > > > > > On 2023/07/24 04:00:37 Guangming Chen wrote: > > > > > > Hi Apache bRPC Community, > > > > > > > > > > > > This is a call for vote to release Apache bRPC version 1.6.0 > > > > > > > > > > > > [Release Note] > > > > > > Feature: > > > > > > - Support user interceptor of server @chenBright #2137 > > > > > > - Support TCP heartbeat of client @chenBright #2098 > > > > > > - Support function name in logging @chenBright #2247 > > > > > > - Support graceful exit gflag for SIGHUP @old-bear #2272 > > > > > > - Support server-end progressive reader for http protocol > > @TangSiyang2001 #2210 > > > > > > - Support new DoublyBufferedData for suspended bthread > @chenBright > > #2225 > > > > > > - Support force SSL for all connections of Acceptor @chenBright > > #2231 > > > > > > - Support fixed and jittered retry backoff policy @chenBright > #2273 > > > > > > - Support release assert @chenBright #2306 > > > > > > > > > > > > Bugfix: > > > > > > - Fix rdma::GlobalRelease before event dispatcher is stopped > > @Tuvie #2220 > > > > > > - Fix compiler optimize thread local variable access @ehds #2156 > > > > > > - Fix butex wait_pthread handle EINTR @jenrryyou #2086 > > > > > > - Fix bvar::MultiDimension::delete_stats() may cause core dump > > @ketor #2237 > > > > > > - Fix compilation errors reported by GCC-13 @adonis0147 #2241 > > > > > > - Fix RDMA device logging @372046933 #2249 > > > > > > - Fix stack buffer overflow issue when calling copy_to_cstr > > @jenrryyou #2253 > > > > > > - Fix resource leak when there are multiple HCAs @372046933 #2252 > > > > > > - Fix unstable keepalive ut @wwbmmm #2261 > > > > > > - Fix coredump stack uncomplete when usercode throw exceptions > > @smbzhang #2256 > > > > > > - Fix compilation errors reported by Clang-14 @thorneliu #2243 > > > > > > - Fix missing BAIDU_GET_VOLATILE_THREAD_LOCAL in task group > > @JimChengLin #2262 > > > > > > - Fix compiler optimize thread local variable access on x86_64 > > @adonis0147 #2248 > > > > > > - Fix compile warning @cdjingit #2274 > > > > > > - Fix core when ssl is enabled without thread safety guarantees > > @warriorpaw #2180 > > > > > > - Fix macos ci failed with protobuf version @wwbmmm #2287 > > > > > > - Fix ignore SIGPIPE signal concurrent issue with other library > > @lrita #2301 > > > > > > - Fix flatmap element space should align with usertype @ehds > #2288 > > > > > > > > > > > > Enhancement: > > > > > > - Support "print all bthread frames" command for gdb bthread > stack > > tool @AIxWall #2217 > > > > > > - Reduce code for operator[] of FlatMap @wy1433 #2202 > > > > > > - Set http default method to "/" @chenBright #2168 > > > > > > - Use Hedron's Compile Commands Extractor for Bazel @372046933 > > #2250 > > > > > > - Initialize offset of round robin load balancer with a random > > number @xiaoma2015 #2289 > > > > > > - Support hint size of formatted string for string_printf > > @chenBright #2270 > > > > > > - Support move constructor for scoped_refptr @byronhe #2284 > > > > > > - Support rvalue task in execution_queue_execute @chenBright > #2308 > > > > > > - Improve/add documents by @Huixxi, @chenBright, @infdahai, > > @372046933, @cdjingit, @ra7more，@Thunderbrook > > > > > > > > > > > > The release candidates: > > > > > > https://dist.apache.org/repos/dist/dev/brpc/1.6.0/ > > > > > > > > > > > > Git tag for the release: > > > > > > https://github.com/apache/brpc/releases/tag/1.6.0/ > > > > > > > > > > > > Release Commit ID: > > > > > > > > > https://github.com/apache/brpc/commit/d2b73ec955dd04b06ab55065d9f3b4de1e608bbd > > > > > > > > > > > > Keys to verify the Release Candidate: > > > > > > https://dist.apache.org/repos/dist/dev/brpc/KEYS > > > > > > > > > > > > The vote will be open for at least 72 hours or until the > necessary > > number of > > > > > > votes are reached. > > > > > > > > > > > > Please vote accordingly: > > > > > > [ ] +1 approve > > > > > > [ ] +0 no opinion > > > > > > [ ] -1 disapprove with the reason > > > > > > > > > > > > PMC vote is +1 binding, all others are +1 non-binding. > > > > > > > > > > > > Checklist for reference: > > > > > > [ ] Download links are valid. > > > > > > [ ] Checksums and PGP signatures are valid. > > > > > > [ ] Source code distributions have correct names matching the > > current > > > > > > release. > > > > > > [ ] LICENSE and NOTICE files are correct for each brpc repo. > > > > > > [ ] All files have license headers if necessary. > > > > > > [ ] No compiled archives bundled in source archive. > > > > > > > > > > > > Regards, > > > > > > Guangming Chen > > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > > > > > For additional commands, e-mail: dev-h...@brpc.apache.org > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > > > > For additional commands, e-mail: dev-h...@brpc.apache.org > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > > > For additional commands, e-mail: dev-h...@brpc.apache.org > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > > For additional commands, e-mail: dev-h...@brpc.apache.org > > > > >
