yanglimingcn commented on code in PR #2358:
URL: https://github.com/apache/brpc/pull/2358#discussion_r1338499097
##########
src/bthread/butex.cpp:
##########
@@ -273,15 +273,16 @@ void butex_destroy(void* butex) {
}
inline TaskGroup* get_task_group(TaskControl* c, bool nosignal = false) {
- TaskGroup* g;
+ TaskGroup* g = tls_task_group;
if (nosignal) {
- g = tls_task_group_nosignal;
- if (NULL == g) {
- g = c->choose_one_group();
+ if (NULL == tls_task_group_nosignal) {
+ g = g ? g : c->choose_one_group();
Review Comment:
这块是尽量选择thread local，感觉更合理。
##########
src/bthread/butex.cpp:
##########
@@ -273,15 +273,16 @@ void butex_destroy(void* butex) {
}
inline TaskGroup* get_task_group(TaskControl* c, bool nosignal = false) {
- TaskGroup* g;
+ TaskGroup* g = tls_task_group;
if (nosignal) {
- g = tls_task_group_nosignal;
- if (NULL == g) {
- g = c->choose_one_group();
+ if (NULL == tls_task_group_nosignal) {
+ g = g ? g : c->choose_one_group();
Review Comment:
这块是尽量选择thread local，感觉更合理。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
