chenzhangyi commented on code in PR #2525:
URL: https://github.com/apache/brpc/pull/2525#discussion_r1472850682
##########
src/brpc/policy/baidu_rpc_protocol.cpp:
##########
@@ -247,6 +247,11 @@ void SendRpcResponse(int64_t correlation_id,
// Send rpc response over stream even if server side failed to create
// stream for some reason.
if(cntl->has_remote_stream()){
+ if (stream_ptr) {
Review Comment:
能不能加一个注释说明下为什么SetConnected一定要在发消息之前设置吗？
如果这里有race的话，后面需要加一个barrier不？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
